Fixes #36849 - Run GHA on Ruby 3.0 by ofedoren · Pull Request #9871 · theforeman/foreman

ofedoren · 2023-10-20T14:12:20Z

@ekohl, this is something I meant during the meeting. As a start point, we could use non-blocking GA to see the status of upgrade to Ruby 3.0. After we're happy with this, we could move the workflow to the shared workflows repo, or leave it here, since I don't think this will be re-used. The next step would be to add Ruby 3.0 to matrix.json and start using shared workflows for the plugins. I could try things out in foreman_webhooks then.

I've also included 2.7 here, since it seems something changed even between 2.7.4 we use in Jenkins and 2.7.8 GA uses.

One test will fail on Ruby 2.7. This may be due to the setup itself, but as a workaround we can use fog/fog-libvirt#133

Few tests will fail on Ruby 3.0. This is mostly because we need to improve safemode library.

Otherwise seems the transition should be smoother than we'd expect. Huge issues though because how kwargs are now treated. Some things must be written carefully, which we... didn't do much.

UPD: requires #9900.

ekohl

This roughly matches what my impression was. kwargs will be a big thing, not too many other issues.

.github/workflows/foreman.yml

ekohl

Some progress on this part: @evgeni and I are working on using .github/matrix.json. #9881 & #9880 do that.

So I'd like to split this PR in 2 parts: introduce GHA based CI that reads matrix.json, which can be blocking. Then the second part is to add Ruby 3.0 to matrix.json and makes sure it passes.

I'm also looking at reporting test failures, possibly to replace Jenkins altogether. https://github.com/marketplace/actions/publish-test-results looks promising.

evgeni · 2023-10-31T18:46:11Z

Some progress on this part: @evgeni and I are working on using .github/matrix.json. #9881 & #9880 do that.

Those are now merged :)

ofedoren · 2023-11-02T13:55:10Z

@ekohl, is that what you meant? I mean, the first commit adds GHA using matrix.json. The second adds Ruby 3 to matrix and fixes.

I can create a separate PR with the first commit, so we can then deal with Ruby 3 here only.

.github/workflows/foreman.yml

test/models/lookup_key_test.rb

ekohl · 2023-11-23T14:50:16Z

These are errors introduced in b566ea8:

 Error:
ApplicationHelperTest::documentation#test_0005_#documentation_url and new docs page:
ArgumentError: wrong number of arguments (given 2, expected 0..1)
    app/helpers/application_helper.rb:308:in `documentation_url'
    test/helpers/application_helper_test.rb:42:in `block (2 levels) in <class:ApplicationHelperTest>'

Error:
ApplicationHelperTest::documentation#test_0004_#documentation_url and new docs page:
ArgumentError: wrong number of arguments (given 2, expected 0..1)
    app/helpers/application_helper.rb:308:in `documentation_url'
    test/helpers/application_helper_test.rb:36:in `block (2 levels) in <class:ApplicationHelperTest>

The others are blocked on theforeman/safemode#44

evgeni · 2023-11-23T18:27:26Z

Shall we merge the existing fixes from this pr (esp. models/host and db/migrate ones) in a separate PR? This would allow plugins to play around with Ruby 3 by adding it manually to the matrix include list while we resolve Safemode issues?

ofedoren · 2023-11-23T19:28:54Z

Do we really want to include such code changes before we branch? :)

That thing https://github.com/theforeman/foreman/pull/9871/files#diff-9daa2c365cb8a7cb177648fe53854dae6588080e089b01333768fcb5da8ff4aeR15-R19, it scares me.

ekohl · 2023-11-24T12:29:49Z

Do we really want to include such code changes before we branch? :)

I think the db/* and test/* changes are safe

That thing https://github.com/theforeman/foreman/pull/9871/files#diff-9daa2c365cb8a7cb177648fe53854dae6588080e089b01333768fcb5da8ff4aeR15-R19, it scares me.

Same ;)

ekohl · 2023-11-29T15:36:06Z

In #9923 I split some of the changes into separate PRs. Perhaps we can merge part of that?

ofedoren · 2023-12-11T15:31:04Z

Hm, seems to be green :)

evgeni · 2023-12-11T16:23:34Z

Nice

ekohl

The method_missing part still scares me. I'll try to do some further digging.

ekohl · 2023-12-18T19:07:35Z

app/models/host.rb

    end
    if type.constantize.respond_to?(method, true)
-      type.constantize.send(method, *args, &block)
+      if method.to_s =~ /\Afind_in_(.*)\Z/ && args.size == 1 && args[0].is_a?(Hash)


I see this is copied from elsewhere, but would this make sense?

Suggested change

if method.to_s =~ /\Afind_in_(.*)\Z/ && args.size == 1 && args[0].is_a?(Hash)

if method.to_s.start_with?('find_in_') && args.size == 1 && args[0].is_a?(Hash)

Gemfile

evgeni · 2024-01-03T11:22:42Z

rebased

ekohl · 2024-01-03T12:29:15Z

test/helpers/application_helper_test.rb


    test '#documentation_url and new docs page' do
-      url = documentation_url('TestSection', { type: 'plugin_manual', name: 'foreman_my_plugin', version: '1.2' })
+      url = documentation_url('TestSection', type: 'plugin_manual', name: 'foreman_my_plugin', version: '1.2')


I should have included these in 441f20a

ekohl · 2024-01-18T12:34:09Z

Closing in favor of #9989

pr-processor bot added the Not yet reviewed label Oct 20, 2023

ofedoren force-pushed the feat-36849-add-ruby-3-ga branch from a81e314 to f887d8b Compare October 20, 2023 14:13

ekohl reviewed Oct 20, 2023

View reviewed changes

.github/workflows/foreman.yml Outdated Show resolved Hide resolved

ofedoren force-pushed the feat-36849-add-ruby-3-ga branch from f887d8b to f2455b3 Compare October 20, 2023 15:05

ekohl changed the title ~~Fixes #36849 - Set up Foreman GA with Ruby 3.0~~ Fixes #36849 - Set up CI with Ruby 3.0 Oct 23, 2023

stejskalleos assigned ekohl Oct 30, 2023

ekohl requested changes Oct 30, 2023

View reviewed changes

pr-processor bot added Waiting on contributor and removed Not yet reviewed labels Oct 30, 2023

ekohl mentioned this pull request Oct 30, 2023

use the values from matrix.json in plugin react tests #9881

Merged

ofedoren force-pushed the feat-36849-add-ruby-3-ga branch from f2455b3 to c39a660 Compare November 2, 2023 13:52

pr-processor bot added Needs re-review and removed Waiting on contributor labels Nov 2, 2023

ofedoren commented Nov 3, 2023

View reviewed changes

.github/workflows/foreman.yml Show resolved Hide resolved

ofedoren mentioned this pull request Nov 10, 2023

Fixes #36913 - Set up GHA with matrix to run test on Ruby 2.7 #9900

Merged

ofedoren force-pushed the feat-36849-add-ruby-3-ga branch from c39a660 to 79cecc6 Compare November 10, 2023 17:53

ofedoren changed the title ~~Fixes #36849 - Set up CI with Ruby 3.0~~ Fixes #36849 - Run GHA on Ruby 3.0 Nov 10, 2023

ekohl reviewed Nov 15, 2023

View reviewed changes

test/models/lookup_key_test.rb Outdated Show resolved Hide resolved

evgeni force-pushed the feat-36849-add-ruby-3-ga branch from 79cecc6 to 9a64fa1 Compare November 23, 2023 13:24

ekohl mentioned this pull request Nov 24, 2023

Fixes #36849 - Run GHA on Ruby 3.0 (alternative) #9923

Closed

ofedoren force-pushed the feat-36849-add-ruby-3-ga branch 2 times, most recently from f39df0f to f822c1f Compare November 27, 2023 13:40

ofedoren mentioned this pull request Nov 27, 2023

Drop Ruby < 2.7 and deal with kwargs theforeman/safemode#44

Merged

ofedoren force-pushed the feat-36849-add-ruby-3-ga branch from f822c1f to fc10249 Compare December 11, 2023 15:04

ofedoren requested a review from a team as a code owner December 11, 2023 15:04

ekohl reviewed Dec 18, 2023

View reviewed changes

evgeni force-pushed the feat-36849-add-ruby-3-ga branch from fc10249 to 03802a5 Compare January 3, 2024 11:22

ekohl mentioned this pull request Jan 3, 2024

Refs #36849 - Ruby 3 preparations #9975

Merged

evgeni force-pushed the feat-36849-add-ruby-3-ga branch from 03802a5 to b23f8a4 Compare January 3, 2024 12:27

ekohl reviewed Jan 3, 2024

View reviewed changes

ekohl mentioned this pull request Jan 10, 2024

Test with Ruby 3 theforeman/foreman_ansible#681

Closed

ofedoren force-pushed the feat-36849-add-ruby-3-ga branch from b23f8a4 to 57c8757 Compare January 12, 2024 10:32

Fixes #36849 - Run GHA on Ruby 3.0

426b5ac

ofedoren force-pushed the feat-36849-add-ruby-3-ga branch from 57c8757 to 426b5ac Compare January 12, 2024 10:34

ofedoren mentioned this pull request Jan 16, 2024

Fixes #36849 - Run GHA on Ruby 3.0 #9989

Merged

ekohl closed this Jan 18, 2024

	if method.to_s =~ /\Afind_in_(.*)\Z/ && args.size == 1 && args[0].is_a?(Hash)
	if method.to_s.start_with?('find_in_') && args.size == 1 && args[0].is_a?(Hash)

Conversation

ofedoren commented Oct 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ekohl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ekohl left a comment

Choose a reason for hiding this comment

Uh oh!

evgeni commented Oct 31, 2023

Uh oh!

ofedoren commented Nov 2, 2023

Uh oh!

Uh oh!

Uh oh!

ekohl commented Nov 23, 2023

Uh oh!

evgeni commented Nov 23, 2023

Uh oh!

ofedoren commented Nov 23, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ekohl commented Nov 24, 2023

Uh oh!

ekohl commented Nov 29, 2023

Uh oh!

ofedoren commented Dec 11, 2023

Uh oh!

evgeni commented Dec 11, 2023

Uh oh!

ekohl left a comment

Choose a reason for hiding this comment

Uh oh!

ekohl Dec 18, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

evgeni commented Jan 3, 2024

Uh oh!

ekohl Jan 3, 2024

Choose a reason for hiding this comment

Uh oh!

ekohl commented Jan 18, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ofedoren commented Oct 20, 2023 •

edited

Loading

ofedoren commented Nov 23, 2023 •

edited

Loading