Skip to content

Fixes #38852 - Move new AutocompleteInput component to foreman core#10734

Merged
adamruzicka merged 1 commit intotheforeman:developfrom
Lukshio:autocompleteInput_move
Jan 22, 2026
Merged

Fixes #38852 - Move new AutocompleteInput component to foreman core#10734
adamruzicka merged 1 commit intotheforeman:developfrom
Lukshio:autocompleteInput_move

Conversation

@Lukshio
Copy link
Contributor

@Lukshio Lukshio commented Oct 22, 2025 •
edited
Loading

Move new AutocompleteInput component from foreman_webhook plugin to foreman core.

Derived from: theforeman/foreman_webhooks#89
Required for: theforeman/foreman_webhooks#91

@github-actions github-actions bot added the UI label Oct 22, 2025
@Lukshio Lukshio closed this Oct 22, 2025
@Lukshio Lukshio force-pushed the autocompleteInput_move branch from e80c002 to 7d08c42 Compare October 22, 2025 15:30
@Lukshio Lukshio reopened this Oct 22, 2025
@Lukshio Lukshio mentioned this pull request Oct 22, 2025
Merged
@Lukshio Lukshio force-pushed the autocompleteInput_move branch from 3cfe5c0 to 4f8cbe6 Compare October 22, 2025 15:46
@Lukshio Lukshio force-pushed the autocompleteInput_move branch from 4f8cbe6 to 28bb71e Compare October 30, 2025 15:43
@MariaAga MariaAga mentioned this pull request Nov 24, 2025
Open
@pondrejk
Copy link
Contributor

pondrejk commented Nov 25, 2025

@Lukshio can we do a rebuild, so that packit can updated on forema 3.18?

@ofedoren
Copy link
Member

ofedoren commented Nov 25, 2025

/packit build

@pondrejk
Copy link
Contributor

pondrejk commented Nov 25, 2025

Checking with stream + packit with this PR and the webhooks one.
There is an e2e UI test for webhooks in robottelo, I'll be running it against this, will report with results.
Otherwise see my comments in theforeman/foreman_webhooks#91

@Lukshio Lukshio force-pushed the autocompleteInput_move branch from 28bb71e to 4a0d2ed Compare November 26, 2025 09:51
@adamruzicka
Copy link
Contributor

adamruzicka commented Nov 28, 2025

/packit build

@kfamilonidis kfamilonidis mentioned this pull request Dec 1, 2025
Open
4 tasks
@Lukshio Lukshio force-pushed the autocompleteInput_move branch from 4a0d2ed to 9948fc2 Compare December 8, 2025 15:24
@Lukshio Lukshio force-pushed the autocompleteInput_move branch from 9948fc2 to f58593e Compare January 22, 2026 13:09
@Lukshio
Copy link
Contributor Author

Lukshio commented Jan 22, 2026

Hi, I updated this PR with the latest changes from theforeman/foreman_webhooks#89 now it should be ready to merge.

@adamlazik1 @adamruzicka

adamlazik1
adamlazik1 approved these changes Jan 22, 2026
View reviewed changes
Copy link
Contributor

@adamlazik1 adamlazik1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll defer to @adamruzicka for merging as I can't do it myself. Left a minor nitpick.

@Lukshio Lukshio force-pushed the autocompleteInput_move branch from f58593e to 61adb0c Compare January 22, 2026 14:59
adamruzicka
adamruzicka approved these changes Jan 22, 2026
View reviewed changes
Copy link
Contributor

@adamruzicka adamruzicka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked with webhooks#91, works just as it did before (well).

@adamruzicka
Copy link
Contributor

adamruzicka commented Jan 22, 2026

Also, go home single commit assertion, you're drunk.

@adamruzicka adamruzicka merged commit 628206f into theforeman:develop Jan 22, 2026
25 of 26 checks passed
@adamruzicka
Copy link
Contributor

adamruzicka commented Jan 22, 2026

Thank you @Lukshio & @adamlazik1 !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@adamruzicka adamruzicka adamruzicka approved these changes

+1 more reviewer

@adamlazik1 adamlazik1 adamlazik1 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

UI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Lukshio @pondrejk @ofedoren @adamruzicka @adamlazik1