Fixes #38737 - Update CardTemplate dropdown for PF5 #10685
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 10, 2025
lfu
force-pushed
the
38185_dropdown_card_template
branch
from
507a4fd to
d5d0359
Compare
Contributor
Author
|
Test failure not related. |
MariaAga
reviewed
Sep 12, 2025
| toggle={toggleRef => ( | ||
| <MenuToggle | ||
| ref={toggleRef} | ||
| id="hostdetails-kebab" |
Member
There was a problem hiding this comment.
There is already a component with this ID
Contributor
Author
There was a problem hiding this comment.
Thanks for catching this.
lfu
force-pushed
the
38185_dropdown_card_template
branch
from
d5d0359 to
6ebb6d5
Compare
MariaAga
reviewed
Sep 12, 2025
| toggle={toggleRef => ( | ||
| <MenuToggle | ||
| ref={toggleRef} | ||
| id="template-card-kebab" |
Member
There was a problem hiding this comment.
Thinking about this, since its a template it might be used twice on the same page, can we just remove the id?
Contributor
Author
There was a problem hiding this comment.
The same thought came to me but I ignored it :)
lfu
force-pushed
the
38185_dropdown_card_template
branch
from
6ebb6d5 to
114db89
Compare
MariaAga
approved these changes
Sep 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup of #10650