Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #38281 - Refactor handling of :include_blank in form_select_f #10484

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

ekohl
Copy link
Member

@ekohl ekohl commented Mar 18, 2025

Ensure proper handling of include_blank in both cases:
when array is an array of options, and when array is a string of HTML options.

(cherry picked from commit 316dd2d)

@pr-processor pr-processor bot added Not yet reviewed Stable branch PRs that are opened against a stable branch. Usually a cherry pick labels Mar 18, 2025
@github-actions github-actions bot added the UI label Mar 18, 2025
Ensure proper handling of `include_blank` in both cases:
when `array` is an array of options, and when `array` is a string of HTML options.

(cherry picked from commit 316dd2d)
@ekohl ekohl force-pushed the more-3.14-picks branch from e3ae594 to c88fe8a Compare March 18, 2025 19:14
@ekohl ekohl changed the title Fixes #38281, #3829 - UI bugfixes for Foreman 3.14 Fixes #38281 - Refactor handling of :include_blank in form_select_f Mar 18, 2025
Copy link
Contributor

@nofaralfasi nofaralfasi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge this? Failing tests don't seem related.

@ekohl ekohl merged commit 75d1d51 into theforeman:3.14-stable Mar 19, 2025
27 of 31 checks passed
@ekohl ekohl deleted the more-3.14-picks branch March 19, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stable branch PRs that are opened against a stable branch. Usually a cherry pick UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants