Fixes #38222 - Add managed interface to ubuntu_autoinst4dhcp snapshot #10450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastian-src
force-pushed
the
fix/ubuntu_snapshots/38222
branch
from
672295c to
42275a7
Compare
|
@stejskalleos can you maybe have a look? This fix completes our snapshot tests of the Ubuntu Autoinstall template. The network config was not rendered before. You can validate this by comparing it to the Ubuntu Autoinstall docs here: https://canonical-subiquity.readthedocs-hosted.com/en/latest/reference/autoinstall-reference.html#network |
The managed interface must be set to render the NIC in snapshots and, therefore, include it in snapshot tests.
bastian-src
force-pushed
the
fix/ubuntu_snapshots/38222
branch
from
42275a7 to
7b3bf00
Compare
stejskalleos
approved these changes
Mar 3, 2025
|
Thanks @bastian-src |
|
Thanks a lot @stejskalleos! :) I came across an issue with the I'm addressing the issue in #10451 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ubuntu Autoinstall template-snapshot-host
ubuntu_autoinst4dhcpdoesn't set its:managed_interfaces. Therefore, the network configuration of the snapshot doesn't include the NIC setup. This PR fixes the issue and updates the template snapshot accordingly.