Fixes #38068 - Consistently use errors.add

app/controllers/usergroups_controller.rb

@@ -37,7 +37,7 @@ def update
       process_error
     end
   rescue Foreman::CyclicGraphException => e
-    @usergroup.errors[:usergroups] << e.record.errors[:base].join(' ')
+    @usergroup.errors.add(:usergroups, e.record.errors[:base].join(' '))
     process_error
   rescue => e
     external_usergroups_error(@usergroup, e)

app/models/compute_resources/foreman/model/ec2.rb

@@ -122,9 +122,9 @@ def test_connection(options = {})
       super
       errors[:user].empty? && errors[:password].empty? && regions
     rescue Fog::AWS::Compute::Error => e
-      errors[:base] << e.message
+      errors.add(:base, e.message)
     rescue Excon::Error::Socket => e
-      errors[:base] << e.message
+      errors.add(:base, e.message)
     end
 
     def console(uuid)

app/models/compute_resources/foreman/model/libvirt.rb

@@ -78,7 +78,7 @@ def test_connection(options = {})
       errors[:url].empty? && hypervisor
     rescue => e
       disconnect rescue nil
-      errors[:base] << e.message
+      errors.add(:base, e.message)
     end
 
     def new_nic(attr = {})

app/models/compute_resources/foreman/model/openstack.rb

@@ -91,7 +91,7 @@ def test_connection(options = {})
       super
       errors[:user].empty? && errors[:password] && tenants
     rescue => e
-      errors[:base] << e.message
+      errors.add(:base, e.message)
     end
 
     def available_images

app/models/compute_resources/foreman/model/vmware.rb

@@ -470,7 +470,7 @@ def test_connection(options = {})
         errors.delete(:datacenter)
       end
     rescue => e
-      errors[:base] << e.message
+      errors.add(:base, e.message)
     end
 
     def parse_args(args)

app/services/host_build_status.rb

@@ -56,6 +56,6 @@ def smart_proxies_status
 
   def fail!(type, message, id = nil)
     @state = false
-    @errors[type] << {:message => message, :edit_id => id}
+    @errors.add(type, {:message => message, :edit_id => id})
   end
 end