Skip to content

build all of Katello on EL9#10410

Merged
evgeni merged 3 commits intotheforeman:rpm/developfrom
evgeni:katello-el9-all
Feb 13, 2024
Merged

build all of Katello on EL9#10410
evgeni merged 3 commits intotheforeman:rpm/developfrom
evgeni:katello-el9-all

Conversation

@evgeni
Copy link
Member

@evgeni evgeni commented Feb 12, 2024

No description provided.

@evgeni
Copy link
Member Author

evgeni commented Feb 12, 2024

Repoclosure is related, needs #10412 which needs Candlepin on EL9

@evgeni evgeni marked this pull request as draft February 12, 2024 12:13
@evgeni
Copy link
Member Author

evgeni commented Feb 12, 2024

Should be merged together with #10412 as that contains katello which requires: rubygem-katello

@evgeni evgeni marked this pull request as ready for review February 12, 2024 16:46
This contradicts the gemspec, but is being worked on.
In the meantime we can adjust the RPM spec and let it build.
Copy link
Member

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will merging this without support in katello master also break the nightly package build?

At least 👍 for the changes once the core PR is merged

@evgeni
Copy link
Member Author

evgeni commented Feb 13, 2024

Will merging this without support in katello master also break the nightly package build?

At least 👍 for the changes once the core PR is merged

That's the hackish beauty of it: As you can see in this PR's test results, things build on EL9 with Ruby 3 and NodeJS 18 just fine.
Several parts of the app are broken (and that's what Katello/katello#10885 is fixing), but it's sufficiently OK to build and produce RPM that can then be tested.
So no, merging this will not break anything, but allow us to produce nightlies that can then be further tested.

@evgeni evgeni merged commit fdee9f8 into theforeman:rpm/develop Feb 13, 2024
@evgeni evgeni deleted the katello-el9-all branch February 13, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants