Add support for darwin ARM cores #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ARM powered Macs do have a heterogenous architecture. This breaks the current parsing logic, as both performance and efficency cores are reported now. Additionally system_profiler does not seem to output 'Number of Processors:' anymore, therefore assume 1 if 'Total Number of Cores:' is present. darwin2 testcase is a redacted sample output for a M1 Machine, which broke before this patch. nose is bumped for python3 support, tests would not run otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARM powered Macs do have a heterogenous architecture. This breaks the current
parsing logic, as both performance and efficency cores are reported now.
Additionally system_profiler does not seem to output 'Number of Processors:'
anymore, therefore assume 1 if 'Total Number of Cores:' is present.
darwin2 testcase is a redacted sample output for a M1 Machine, which broke
before this patch.
nose is bumped for python3 support, tests would not run otherwise.
Overall this is really a minimum effort fix, feel free to implement something more clever or discard it entirely. Only stumbled across this as it is used in blender-benchmark-script.