Public poll functions #173
Closed
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bootuz
changed the title
tristanlabelle
force-pushed
the
public_internal
branch
from
5d7e0ee to
66ba21e
Compare
| @@ -5,7 +5,7 @@ import struct Dispatch.DispatchTime | |||
| /// Calls a closure repeatedly with exponential backoff until it reports success or a timeout elapses. | |||
| /// Thrown errors bubble up immediately, returned errors allow retries. | |||
| /// - Returns: The successful value. | |||
| internal func poll<Value>( | |||
| public func poll<Value>( | |||
There was a problem hiding this comment.
I think providing a poll function is out of scope for swift-webdriver as a library, even if it needs it internally. I'd be curious to see what your use case is though, in case there are functionality gaps to be filled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made
pollfunctions public to be able to use them in libraries that useswift-webdriveras a dependency to avoid code duplication.