Skip to content

Commit

Permalink
Support arm64 in release binary sizes workflow
Browse files Browse the repository at this point in the history
  • Loading branch information
kendal committed Apr 26, 2024
1 parent 4cae311 commit 60f9aba
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/release-swift-toolchain-binary-sizes.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
#
name: Release - Swift Toolchain Binary Sizes

# TODO(thebrowsercompany/swift-build/issues/129): Support arm64 releases.
# TODO(kendal): Use on.releases.[created, edited] when the table schema is stable.

on:
Expand Down Expand Up @@ -47,7 +46,7 @@ jobs:

strategy:
matrix:
toolchain_arch: [amd64]
toolchain_arch: [amd64, arm64]

steps:
- name: Checkout swift-build
Expand Down Expand Up @@ -110,6 +109,7 @@ jobs:
$Script="./scripts/python/binary_sizes/bigquery_generate_table_data.py"
python ${Script} ${{ github.workspace }}/binary_sizes.csv ${{ github.workspace }}/table_data.csv `
--toolchain-version=${{ env.SWIFT_TOOLCHAIN_VERSION }} `
--toolchain-arch=${{ matrix.toolchain_arch }} `
--strip-inputfiles-prefix=${{ env.SWIFT_INSTALL_ROOT }} `
--environment="${{ env.ENVIRONMENT_LABEL }}" `
--creation-time="$CreationTime"
Expand Down
3 changes: 2 additions & 1 deletion scripts/python/binary_sizes/bigquery_generate_table_data.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ def main():

req_group = parser.add_argument_group('required flags', 'Additional properties that help slice and group data in BigQuery')
req_group.add_argument('--toolchain-version', type=str, help='The toolchain version that corresponds to the input data')
req_group.add_argument('--toolchain-arch', type=str, help='The toolchain target architecture')

opt_group = parser.add_argument_group('optional flags')
opt_group.add_argument('--creation-time', type=str, help='timestamp when the release was created formatted as YYYY-MM-DD')
Expand All @@ -63,7 +64,7 @@ def main():
add_column(csv_data, 'toolchain_version', args.toolchain_version)
add_column(csv_data, 'environment', args.environment)
add_column(csv_data, 'target_os', 'windows')
add_column(csv_data, 'target_arch', 'amd64')
add_column(csv_data, 'target_arch', args.toolchain_arch)
add_column(csv_data, 'creation_time', creation_time)
rename_column(csv_data, 'inputfiles', 'filename')
rename_column(csv_data, 'segments', 'segment')
Expand Down

0 comments on commit 60f9aba

Please sign in to comment.