Feature: Swift argument parser #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 22, 2020 14:41
# Conflicts: # configen/OptionsParser.swift
bengilroy
approved these changes
Jul 28, 2020
bengilroy
left a comment
bengilroy
left a comment
There was a problem hiding this comment.
Looks good! A couple of things:
- As we discussed on Slack it seems well have to use Xcode 11.4 and above to contribute to Configen from now on, perhaps we should add something to the readme to point this out?
- I'd maybe update the configen binary in the ConfigenDemo app to the new one (I did this to test it and it shows as modified on git so think it needs updating anyway).
| return """ | ||
| // auto-generated by \(optionsParser.appName)\n// to add or remove properties, edit the mapping file: '\(optionsParser.inputHintsFilePath)'.\n// README: https://github.com/theappbusiness/ConfigGenerator/blob/master/README.md\n\n | ||
| // auto-generated by \(options.appName)\n// to add or remove properties, edit the mapping file: '\(options.inputHintsFilePath)'.\n// README: https://github.com/theappbusiness/ConfigGenerator/blob/master/README.md\n\n | ||
| """ |
There was a problem hiding this comment.
Unrelated, but if we're using a multi-line string we could just use return as normal instead of manually entering \n – unless it's there for another reason.
There's also a few other normal strings that are using \n so for readability we could consider making those multiline too, if we feel it does make it more readable that is. Could be something for a future PR anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the old CommandLineKit dependency in favour of the Swift Argument Parser package (see https://swift.org/blog/argument-parser/). This change IS backwards compatible.