Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SIRIND's Tomak79H #56

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add SIRIND's Tomak79H #56

wants to merge 3 commits into from

Conversation

eerraa
Copy link

@eerraa eerraa commented Jan 24, 2025

Add SIRIND's Tomak79H

Description

This is the Hotswap PCB for SIRIND's Tomak.
Please allow me to add this to the VIA.

QMK Pull Request

qmk/qmk_firmware#24505

Checklist

  • The VIA support for this keyboard is MERGED in QMK master already (MANDATORY)
  • I have tested this keyboard definition with firmware on a device.(MANDATORY)
  • VIA keymap uses custom menus
  • The Vendor ID is not 0xFEED

@Cipulot
Copy link

Cipulot commented Feb 2, 2025

@eerraa if the custom UI elements code is shared for this board and #43 I suggest making a common file to be included to avoid code duplication.
Something like keyboards/era/sirind/common/tomak_custom_ui.c and keyboards/era/sirind/common/tomak_custom_ui.h for header inclusions.

I saw that similar code is used in #44 but not all code is shared, so later if for that board you have common code as well, that one can be something like keyboards/era/sirind/common/brick_custom_ui.c and keyboards/era/sirind/common/brick_custom_ui.h

@Cipulot Cipulot added the needs work The PR needs fixes/ things need to be addressed label Feb 2, 2025
@Cipulot Cipulot mentioned this pull request Feb 2, 2025
4 tasks
@eerraa
Copy link
Author

eerraa commented Feb 2, 2025

@Cipulot
As you suggested, I have created a common file for the Custom UI.
This is because Tomak79H and Tomak79S share Custom UI code.
Thank you for your assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs work The PR needs fixes/ things need to be addressed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants