Skip to content

Security: Path traversal/arbitrary file write risk in parallel copy worker #468

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tuanaiseo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Security: Path traversal/arbitrary file write risk in parallel copy worker #468

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/copy-worker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,17 @@ const { files, sourceBase, destBase } = workerData;
let copied = 0;
let skipped = 0;
const errors = [];
const resolvedDestBase = path.resolve(destBase);

for (const relativePath of files) {
const srcPath = path.join(sourceBase, relativePath);
const destPath = path.join(destBase, relativePath);
const destPath = path.resolve(destBase, relativePath);

if (destPath !== resolvedDestBase && !destPath.startsWith(resolvedDestBase + path.sep)) {
skipped++;
errors.push({ file: relativePath, error: 'Invalid destination path' });
continue;
}

try {
// Ensure parent directory exists
Expand Down