Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change armor plates to use zones #303

Merged
merged 1 commit into from
Jun 17, 2024
Merged

change armor plates to use zones #303

merged 1 commit into from
Jun 17, 2024

Conversation

Razzmatazzz
Copy link
Member

Previously ItemPropertiesArmorAttachment was only used by helmet attachments, so the zones field was called headZones. Since armor plates use this same properties type, this PR deprecates headZones and introduces zones in its place.

@Razzmatazzz Razzmatazzz requested a review from a team as a code owner June 15, 2024 15:21
Copy link
Contributor

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down summary of our deployment process below:

  1. 👀 Observe the CI jobs and tests to ensure they are passing

  2. ✔️ Obtain an approval/review on this pull request

  3. 🚀 Deploy your pull request to the development environment with .deploy to development

  4. 🚀 Deploy your pull request to the production environment with .deploy

    If anything goes wrong, rollback with .deploy main

  5. 🎉 Merge!

Need help? Type .help as a comment or visit the usage guide for more details

Please note, if you have a more complex change, it is advised to claim a deployment lock with .lock <environment> --reason <reason> to prevent other deployments from happening while you are working on your change.

Once your PR has been merged, you can remove the lock with .unlock <environment>.

@Razzmatazzz
Copy link
Member Author

.deploy

Copy link
Contributor

Deployment Triggered 🚀

Razzmatazzz, started a branch deployment to production

You can watch the progress here 🔗

Branch: armor-plate-zones

Copy link
Contributor

API Deployment - Production 🌔

The API has been deployed to the production environment 🚀

Pusher: @Razzmatazzz, Action: issue_comment, Workflow: branch-deploy;

Copy link
Contributor

Deployment Results ✅

Razzmatazzz successfully deployed branch armor-plate-zones to production

Environment URL: api.tarkov.dev/graphql

@Razzmatazzz Razzmatazzz merged commit 4a86792 into main Jun 17, 2024
4 checks passed
@Razzmatazzz Razzmatazzz deleted the armor-plate-zones branch June 17, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants