Conversation
aifrim
suggested changes
Sep 25, 2019
| return $response->withStatus(400, 'Invalid Json'); | ||
| } | ||
| $characters = $request->getBody(); | ||
| $GLOBALS['db']->dnd->characters->insertOne(json_decode($characters, true)); |
Contributor
There was a problem hiding this comment.
$character = new Character(json_decode($payload);
insert($character);Only take from the $payload the actual properties you require.
Return a 400 Bad Request if the $payload does not have all the required properties.
| $app->post('/characters', function (Request $request, Response $response) { | ||
| $request_type = $request->getHeader('CONTENT_TYPE'); | ||
| if($request_type[0] != 'application/json'){ | ||
| $response->getBody()->write('Only application/json accepted'); |
Contributor
There was a problem hiding this comment.
Better throw a Slim\Exception\HttpBadRequestException
| $response->getBody()->write('Character generated successfully'); | ||
| return $response->withStatus(200); | ||
| foreach ($characters as $character) { | ||
| $response->getBody()->write(json_encode($character, JSON_PRETTY_PRINT)); |
Contributor
There was a problem hiding this comment.
No need to JSON_PRETTY_PRINT.
But if you really want to, only do so in development, not production.
Maybe use a env var to state the environment type?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented get and post for character endpoints in order to have a basis for a discussion about the actual design.