Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update: tab in browser updated #54

Merged
merged 1 commit into from
Oct 7, 2024
Merged

update: tab in browser updated #54

merged 1 commit into from
Oct 7, 2024

Conversation

arandel1
Copy link
Collaborator

@arandel1 arandel1 commented Oct 4, 2024

For an example of how to fill this template out, see this Pull Request.

Description

  • Updated index.html and changed title of app to SnapShop
  • Imported new png for tab logo

Related Issue

closes 53

Acceptance Criteria

Acceptance Criteria

  • Icon is relevant to SnapShop as a brand
  • Tab reads "SnapShop" instead of "Smart Shopping List"

Type of Changes

enhancement

Updates

Before

After

Testing Steps / QA Criteria

  • Pull from ar-tab-updates-issue-27
  • See the tab in browser

Copy link

github-actions bot commented Oct 4, 2024

Visit the preview URL for this PR (updated for commit 535368a):

https://tcl-76-smart-shopping-list--pr54-ar-tab-updates-issue-sen59ccq.web.app

(expires Fri, 11 Oct 2024 14:29:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 512b1a88be8ae05fd3e727b99332819df760271d

@EmmaBin EmmaBin self-requested a review October 5, 2024 03:03
Copy link
Collaborator

@EmmaBin EmmaBin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love how the color of the icon complements our background color

@sar-mko
Copy link
Collaborator

sar-mko commented Oct 6, 2024

Very cute, I like it!

@sar-mko sar-mko self-requested a review October 6, 2024 15:54
@arandel1 arandel1 merged commit 7089996 into main Oct 7, 2024
3 checks passed
@arandel1 arandel1 deleted the ar-tab-updates-issue-27 branch October 7, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants