Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new tests #7737

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mmaryo
Copy link
Contributor

@mmaryo mmaryo commented Sep 8, 2024

No description provided.

@mmaryo mmaryo requested a review from waghanza as a code owner September 8, 2024 06:34
@medz

This comment was marked as resolved.

@waghanza
Copy link
Collaborator

I don't think your PR is good! First of all, there is no thread about planning and discussing new test proposals before.

The idea is to based a discussion on this 😛

Secondly, it is very irresponsible to implement Spring under Java category.

Why ?

You should turn your PR into a draft and update other frameworks to it within your ability.

The idea is to add some endpoint for a v2 on results, I mean the whole idea is to avoid being just a hello world

Your current approach is very irresponsible, and you transfer a huge workload to others.

I do not understand it @medz . Could you explain a bit ?

From your PR, you are very familiar with Java, and you should at least update other frameworks under Java in a unified way.

Your idea is good, but the first we should have tests to make sure this works, and after make sure we can uniformize java implementations (this is planed as so)

@medz
Copy link
Contributor

medz commented Mar 19, 2025

#7732

I just noticed this discussion, so the above statement is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants