fix(agent): focus agents by pane id - #19
Open
dmissoh wants to merge 1 commit into
Open
Conversation
herdr resolves agent targets by pane id only; terminal ids return agent_not_found, so every agent row failed to focus. Keep terminal_id in search_terms. Fixes thanhdat77#18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #18.
Agent rows never focus:
FocusAgenttargetsterminal_id, but herdr resolves agent targets bypane_idonly.terminal_idis always present inherdr agent listoutput, so the existingunwrap_or(pane)fallback never fires and every agent row is affected.Change
Focus by
pane_id, falling back toterminal_idifpane_idis ever absent.terminal_idstays insearch_terms, so searching an agent by its terminal id still matches.Verification
cargo test: 65 pass, 2 failures (close_target_matches_entry_kind,source_specific_reuse_distinguishes_same_path_workspaces) that also fail on unmodifiedmain— both query a live herdr server.cargo fmt --checkclean.cargo clippy --all-targetsunchanged: one pre-existingitems after a test modulewarning insrc/main.rs.