Use BottomSheetModalProps instead of BottomSheetProps as navigation options #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codybrouwers
changed the title
janicduplessis
approved these changes
Sep 12, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there, thanks for this library, it has been very useful!
I came across an issue that this PR attempts to fix. I wanted to use the
stackBehavioroption but it is added byBottomSheetModalProps. Since this library'sBottomSheetViewcomponent does use theBottomSheetModalabstraction from@gorhom/bottom-sheet, I believe this library's props should also inherit the same props.I think this might also fix this issue:
Thank you!