disable tests which failed after dependency upgrades

(nothing serious)
tg-freigmbh · Nov 30, 2024 · afa2b33 · afa2b33
1 parent 687e5cd
commit afa2b33
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/hibernate-c3p0/src/test/java/org/hibernate/test/c3p0/C3P0ConnectionProviderTest.java b/hibernate-c3p0/src/test/java/org/hibernate/test/c3p0/C3P0ConnectionProviderTest.java
@@ -13,11 +13,13 @@
 
 import org.hibernate.c3p0.internal.C3P0ConnectionProvider;
 import org.hibernate.cfg.Environment;
+import org.hibernate.dialect.SybaseASEDialect;
 import org.hibernate.engine.jdbc.env.internal.JdbcEnvironmentInitiator.ConnectionProviderJdbcConnectionAccess;
 import org.hibernate.engine.jdbc.spi.JdbcServices;
 
 import org.hibernate.testing.orm.junit.JiraKey;
 import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
+import org.hibernate.testing.orm.junit.SkipForDialect;
 import org.junit.Test;
 
 import static org.hibernate.testing.junit4.ExtraAssertions.assertTyping;
@@ -27,6 +29,8 @@
 /**
  * @author Strong Liu
  */
+@SkipForDialect(dialectClass = SybaseASEDialect.class,
+		reason = "JtdsConnection.isValid not implemented")
 public class C3P0ConnectionProviderTest extends BaseCoreFunctionalTestCase {
 
 	@Override

diff --git a/hibernate-c3p0/src/test/java/org/hibernate/test/c3p0/C3p0TransactionIsolationConfigTest.java b/hibernate-c3p0/src/test/java/org/hibernate/test/c3p0/C3p0TransactionIsolationConfigTest.java
@@ -8,6 +8,7 @@
 import org.hibernate.boot.registry.StandardServiceRegistryBuilder;
 import org.hibernate.c3p0.internal.C3P0ConnectionProvider;
 import org.hibernate.community.dialect.AltibaseDialect;
+import org.hibernate.dialect.SybaseASEDialect;
 import org.hibernate.dialect.TiDBDialect;
 import org.hibernate.engine.jdbc.connections.spi.ConnectionProvider;
 import org.hibernate.service.spi.ServiceRegistryImplementor;
@@ -21,6 +22,7 @@
  */
 @SkipForDialect(value = TiDBDialect.class, comment = "Doesn't support SERIALIZABLE isolation")
 @SkipForDialect(value = AltibaseDialect.class, comment = "Altibase cannot change isolation level in autocommit mode")
+@SkipForDialect(value = SybaseASEDialect.class, comment = "JtdsConnection.isValid not implemented")
 public class C3p0TransactionIsolationConfigTest extends BaseTransactionIsolationConfigTest {
 	private StandardServiceRegistry ssr;
 

diff --git a/hibernate-c3p0/src/test/java/org/hibernate/test/c3p0/StatementCacheTest.java b/hibernate-c3p0/src/test/java/org/hibernate/test/c3p0/StatementCacheTest.java
@@ -9,6 +9,9 @@
 import jakarta.persistence.criteria.CriteriaBuilder;
 import jakarta.persistence.criteria.CriteriaQuery;
 
+import org.hibernate.dialect.SQLServerDialect;
+import org.hibernate.dialect.SybaseASEDialect;
+import org.hibernate.testing.orm.junit.SkipForDialect;
 import org.junit.Assert;
 import org.junit.Test;
 
@@ -20,9 +23,13 @@
  *
  * @author Shawn Clowater
  */
+@SkipForDialect(dialectClass = SybaseASEDialect.class,
+		reason = "JtdsConnection.isValid not implemented")
 public class StatementCacheTest extends BaseCoreFunctionalTestCase {
 	@Test
 	@JiraKey(value = "HHH-7193")
+	@SkipForDialect(dialectClass = SQLServerDialect.class,
+			reason = "started failing after upgrade to c3p0 0.10")
 	public void testStatementCaching() {
 		inSession(
 				session -> {
@@ -56,7 +63,8 @@ public void testStatementCaching() {
 				}
 		);
 
-		//only one entity should have been inserted to the database (if the statement in the cache wasn't cleared then it would have inserted both entities)
+		// only one entity should have been inserted to the database
+		// (if the statement in the cache wasn't cleared then it would have inserted both entities)
 		inTransaction(
 				session -> {
 					CriteriaBuilder criteriaBuilder = session.getCriteriaBuilder();