feat(registry): implement FromProof for Registry#1083
Conversation
aeb13d1 to
ec7cca9
Compare
|
Benchmark results for revision f02795e:
Full results
Compare the results above with those for the default branch. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1083 +/- ##
==========================================
- Coverage 90.09% 90.05% -0.04%
==========================================
Files 130 130
Lines 28355 28352 -3
Branches 28355 28352 -3
==========================================
- Hits 25547 25533 -14
- Misses 2045 2055 +10
- Partials 763 764 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
victor-dumitrescu
left a comment
There was a problem hiding this comment.
LGTM. Do you think it would be useful to add an ignored test which attempts proof_binary::deserialise::<Registry<KV, Verify>>(...)? Could also leave for when TZX-161 gets resolved.
I think so! I'm in the process of writing some e2e tests which demonstrate the currently missing gaps - which will include this indeed 🙏🏻 I had intended them as a follow up - but actually it turns out it's preferable to do so now, as there's an additional change needed. |
What
Implement
FromProofforRegistryWhy
Required to deserialise a proof, and to recover the
Registry<Verify>instanceHow
mostly done by the verify mode for
VectorManually Testing
Tasks for the Author