feat(dursto): define cfg aliases for test features at build time#1078
Merged
Conversation
|
Benchmark results for revision 71e68c2:
Full results
Compare the results above with those for the default branch. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1078 +/- ##
=======================================
Coverage 90.08% 90.09%
=======================================
Files 130 130
Lines 28355 28355
Branches 28355 28355
=======================================
+ Hits 25545 25546 +1
- Misses 2047 2048 +1
+ Partials 763 761 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
thomasathorne
approved these changes
Jun 4, 2026
kurtisc
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes RV-1002.
What
Introduces 3 build-time cfg aliases:
#[cfg(test_utils)]as an alias for#[cfg(feature = "unstable-test-utils")](and also#[cfg(any(test, feature = "unstable-test-utils"))]becausetestalways builds with theunstable-test-utilsflag).#[cfg(rocksdb)]as an alias for#[cfg(feature = "rocksdb")]#[cfg(rocksdb_test_utils)]as an alias for#[cfg(all(feature = "unstable-test-utils", feature = "rocksdb"))]. This one is not yet used anywhere but will be used for the long tests binary.Why
Simplifies cfg attributes, especially in test code.
How
As part of a newly introduced build script. All relevant attributes changed.
Manually Testing
Tasks for the Author