Skip to content

Cleaner and more straightforward version when using proxy server #2728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: 3.2
Choose a base branch
from

Conversation

w4ntun
Copy link

@w4ntun w4ntun commented Apr 2, 2025

Describe your changes

Please refer to an issue here or describe the change thoroughly in your PR: #2719

What is your pull request about?

  • Bug fix
  • Improvement
  • New feature (adds functionality)
  • Breaking change (bug fix, feature or improvement that would cause existing functionality to not work as expected)
  • Typo fix
  • Documentation update
  • Update of other files

If it's a code change please check the boxes which are applicable

  • For the main program: My edits contain no tabs, indentation is five spaces and any line endings do not contain any blank chars
  • I've read CONTRIBUTING.md and Coding_Convention.md
  • I have tested this fix or improvement against >=2 hosts and I couldn't spot a problem
  • I have tested this new feature against >=2 hosts which show this feature and >=2 host which does not (in order to avoid side effects) . I couldn't spot a problem
  • For the new feature I have made corresponding changes to the documentation and / or to help()
  • If it's a bigger change: I added myself to CREDITS.md (alphabetical order) and the change to CHANGELOG.md

@drwetter
Copy link
Collaborator

drwetter commented Apr 2, 2025

Hi @w4tun,

thanks. Actually I was only wondering why we didn't set it to true.

Can you comment on the other changes please other than "cleaner and more straightforward approach"?

FYI: It might not be the right time yet to merge this PR as this point of time I don't know yet whether want a breaking change.

@w4ntun w4ntun force-pushed the 3.1dev branch 3 times, most recently from 38610a6 to 0e90d55 Compare April 12, 2025 17:59
@w4ntun
Copy link
Author

w4ntun commented Apr 12, 2025

Thanks @drwetter . PR rebased and commented on #2719. Let me know if you need more info from my side. Cheers.

@drwetter
Copy link
Collaborator

Thanks! Some days after Easter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants