Add testing with multiple services#39
Merged
olivierwilkinson merged 3 commits intomainfrom Sep 22, 2022
Merged
Conversation
Currently we are only testing using the selenium-standalone service. Since other services interact with the browser differently we must run the tests using those services to check we are compatible with them. Update the test setup so that we check: Puppeteer (default wdio behaviour), Chromedriver, Geckodriver and Selenium Standalone.
When using Puppeteer to drive the browser it adds extra attributes to identify the element. This breaks the test for refetching elements as we are checking the stringified elements are the same, however the element identifier added by Puppeteer has changed. Check that the refetched element has the correct text instead.
When testing a production React application Puppeteer is unable to serialise the elements due to circular references from React Fiber. The tests include a basic `getByText` test and another for checking refetching after a key change. The later is important as key changes are common in React. Skip the tests until they pass with Puppeteer as well.
8523704 to
16a7be6
Compare
|
🎉 This PR is included in version 3.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds failing test cases that reproduce the issue found in #29