Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add tests for Node 16 #165

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

chore: add tests for Node 16 #165

wants to merge 2 commits into from

Conversation

MichaelDeBoey
Copy link
Member

@MichaelDeBoey MichaelDeBoey commented Apr 21, 2021 •
edited
Loading

@MichaelDeBoey MichaelDeBoey requested a review from nickserv June 3, 2021 15:20
@nickserv
Copy link
Member

Technically, adding any engines here is a breaking change, since it could prevent installations from users on older Node versions. I think we should revert commit that unless we're ready to release this PR as a breaking change.

@MichaelDeBoey
Copy link
Member Author

It technically is, but since other versions weren't supported anyways, I don't see any problem with adding them as I did.

@nickserv
Copy link
Member

nickserv commented Jul 20, 2021 •
edited
Loading

We could publish this as a minor, and worst case if there are back compatibility issues (probably unlikely), we could revert it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickserv nickserv nickserv requested changes

Assignees
No one assigned
Labels
STATE: Need response
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichaelDeBoey @nickserv