Add support for additional headers#10
Closed
arashnd wants to merge 1 commit intotestdouble:mainfrom
Closed
Conversation
Member
|
This is a good idea. We need to add this for the other endpoints with headers too. |
Member
|
I don't have auth to push on your branch, I will close this PR and reopen with #33 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for incredible gem!!
In our app we want the ability to pass additional headers (We have custom ActiveStorage::Service class inherits from
ActiveStorage::Service::AzureBlobService)There are many use cases where want to send additional headers for example Customer Provided Keys for Encryption
Azure/azure-storage-ruby#221
https://learn.microsoft.com/en-us/azure/storage/blobs/encryption-customer-provided-keys
https://learn.microsoft.com/en-us/rest/api/storageservices/put-blob
Change is fairly simple but I can improve this PR further if necessary.