Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Docker Send and Sync #384

Merged
merged 4 commits into from
Jul 19, 2022
Merged

Make Docker Send and Sync #384

merged 4 commits into from
Jul 19, 2022

Conversation

ufoscout
Copy link
Contributor

@ufoscout ufoscout commented Jul 6, 2022 •
edited
Loading

This fixes #354 allowing singleton instances of a container.
Fixes #381 also

@ufoscout ufoscout mentioned this pull request Jul 6, 2022
Closed
thomaseizinger
thomaseizinger requested changes Jul 7, 2022
View reviewed changes
Copy link
Collaborator

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Concept ACK, just one suggestion on how we can write the test.

testcontainers/tests/container.rs Outdated Show resolved Hide resolved
@thomaseizinger
Copy link
Collaborator

I've pushed #385. Need to wait for it to merge before we can merge this.

@ufoscout
Copy link
Contributor Author

I've pushed #385. Need to wait for it to merge before we can merge this.

Now that #385 was merged, this one could be merged too.

thomaseizinger
thomaseizinger approved these changes Jul 19, 2022
View reviewed changes
Copy link
Collaborator

@thomaseizinger thomaseizinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 19, 2022

Build succeeded:

@bors bors bot merged commit 9271733 into testcontainers:dev Jul 19, 2022
@neverchanje neverchanje mentioned this pull request Mar 5, 2023
Closed
@thomaseizinger thomaseizinger mentioned this pull request Sep 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomaseizinger thomaseizinger thomaseizinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Container and Cli are no longer "Send" Singleton instace of a container
2 participants
@ufoscout @thomaseizinger