-
-
Couldn't load subscription status.
- Fork 584
chore(qdrant): use Run function #3427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(qdrant): use Run function #3427
Conversation
This commit updates the qdrant module to use the new Run() API from testcontainers-go, replacing the deprecated GenericContainer approach. The migration converts exposed ports and wait strategy to moduleOpts, simplifying the container creation process. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
✅ Deploy Preview for testcontainers-go ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Summary by CodeRabbit
WalkthroughRefactors modules/qdrant/qdrant.go to replace GenericContainerRequest/GenericContainer with testcontainers.Run using a composed slice of ContainerCustomizer options (e.g., WithExposedPorts, WithWaitStrategy). Removes the manual customization loop, updates container instantiation, and adjusts the error message to "run qdrant: %w". Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Caller as Caller
participant QMod as Qdrant.Run
participant TC as testcontainers.Run
participant Engine as Container Runtime
Caller->>QMod: Run(ctx, img, opts...)
QMod->>QMod: compose moduleOpts (WithExposedPorts, WithWaitStrategy, ...)
QMod->>TC: Run(ctx, img, moduleOpts...)
TC->>Engine: create & start container
Engine-->>TC: container handle or error
TC-->>QMod: ctr, err
alt success
QMod-->>Caller: ctr
else error
QMod-->>Caller: error ("run qdrant: %w")
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
What does this PR do?
Use the Run function in qdrant
Why is it important?
Migrate modules to the new API, improving consistency and leveraging the latest testcontainers functionality.
Related issues