Integrate with Kubernetes #22

Activity

1. gianarb

   added

   enhancement

   on Nov 23, 2018
2. gianarb commented on Nov 23, 2018

   

   gianarb

   on Nov 23, 2018

   Last edited by gianarb

   Member

   More actions

   Yep, this is a good idea, I think we should create a Container interface with the current functions we implemented in the container like:

   type Container interface{
        Terminate(ctx context.Context, t *testing.T) error
        LivenessCheckPorts(ctx context.Context) (nat.PortSet, error) 
        GetIPAddress(ctx context.Context) (string, error)
        GetHostEndpoint(ctx context.Context, port string) (string, string, error)
   }

   And we can have a new file kubernetes.go that implements that interface with a function RunPod (it should return a container just like RunContainer but via kubernetes (a pod).

   Nice idea! I don't think this is a top priority btw. For example, I am using this library in a project and we use Jenkins to run tests against kubernetes but we use Docker in Docker. I am not sure about the benefits of having the ability to run pods directly. What do you think?
3. mraerino commented on Nov 23, 2018

   

   mraerino

   on Nov 23, 2018

   ContributorAuthor

   More actions

   That sounds great!
4. mraerino commented on Nov 25, 2018

   

   mraerino

   on Nov 25, 2018

   ContributorAuthor

   More actions

   The foundation for this has been laid in #36
5. rnorth commented on Nov 26, 2018

   

   rnorth

   on Nov 26, 2018

   Member

   More actions

   This is probably something we should do with the Java implementation and other forks, at the right time. Please could we discuss the general approach to tackling this?

   I can't think of anything specific, but it would be good for all the implementations to be gradually moving towards convergence on feature sets rather than divergence 😄 .
6. gianarb commented on Nov 26, 2018

   

   gianarb

   on Nov 26, 2018 via email

   Member

   More actions

   We have a lot to fix before this. So yes! Let's work on this together when everyone will be ready.

   …

   On Mon, Nov 26, 2018, 22:03 Richard North ***@***.*** wrote: This is probably something we should do with the Java implementation and other forks, at the right time. Please could we discuss the general approach to tackling this? I can't think of anything specific, but it would be good for all the implementations to be gradually moving towards convergence on feature sets rather than divergence 😄 . — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#22 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABjgO2fZEjzfh7eycZhEmDk9WlEJcSX6ks5uzFcPgaJpZM4Yv8cC> .
7. gianarb

   removed

   enhancement

   on Sep 4, 2019
8. mdelapenya commented on Aug 25, 2022

   

   mdelapenya

   on Aug 25, 2022

   Member

   More actions

   I think it makes sense to move this thread to Discussions
9. testcontainers

   locked and limited conversation to collaborators on Aug 25, 2022
10. mdelapenya

    converted this issue into a discussion #510 on Aug 25, 2022