fix(mosquitto): module name #97
Conversation
|
Could you resolve conflicts 🙏 ? Then we can proceed with the merge |
| @@ -4,7 +4,7 @@ categories: | |||
| - message-broker | |||
| docs: | |||
| - id: python | |||
| url: https://testcontainers-python.readthedocs.io/en/latest/modules/mqtt/README.html | |||
| url: https://testcontainers-python.readthedocs.io/en/latest/modules/mosquitto/README.html | |||
There was a problem hiding this comment.
I think this URL is correct, so I'm not sure of the validity of this PR.
There was a problem hiding this comment.
testcontainers/testcontainers-python#740 suggests to rename the module. If so, then this change applies.
| @@ -13,7 +13,7 @@ docs: | |||
| ``` | |||
| installation: | | |||
| ```bash | |||
| pip install testcontainers[mqtt] | |||
| pip install testcontainers[mosquitto] | |||
There was a problem hiding this comment.
question: could you point me to the pip link to install the package so I can verify if this change is also needed? I was not able to locate it myself 😞
There was a problem hiding this comment.
the "extra" which is mqtt today and is being requested to be changed to mosquitto in the docs above is in fact listed here - https://github.com/testcontainers/testcontainers-python/blob/9317736c34cbe23844006c8e49629fc88e142949/pyproject.toml#L146
There is typos in documentation and problem with naming convention of mosquitto module in testcontainers-python.
I have prepared RP to fix name testcontainers/testcontainers-python#740
Once it will be merged, documentation should be updated
Thanks!