Skip to content

trigger ci#26

Open
testcara wants to merge 85 commits into
mainfrom
trigger-ci
Open

trigger ci#26
testcara wants to merge 85 commits into
mainfrom
trigger-ci

Conversation

@testcara
Copy link
Copy Markdown
Owner

Fixes

Description

Type of change

  • Feature
  • Bugfix
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Screen shots / Gifs for design review

How to test or reproduce?

Browser conformance:

  • Chrome
  • Firefox
  • Safari
  • Edge

testcara added 13 commits March 9, 2026 13:42
Konflux Staging update cara-konflux-ui-test-b1228
  - Add secret parameters to e2e-main-pipeline
  - Update run-e2e-konflux-ui task with Cypress and Slack credentials
  - Update check-org-membership task with GitHub token
  - Update IntegrationTestScenario with all secret parameters
  - Add example PipelineRun for manual testing

  This migration enables running E2E tests in Kubernetes with proper
  credentials management instead of GitHub Actions secrets.
- Check EVENT_TYPE before parsing PR-specific fields
- Use jq default values to handle missing/malformed JSON fields
- Fix 'parse error: Expected value before comma' for push events
- Set pull_request_number to JSON null instead of empty value
- Set pull_request_author to JSON null instead of string 'null'
- Fix 'parse error: Expected value before comma' in job-spec JSON

For push events, the generated JSON will now be:
  "pull_request_number": null,
  "pull_request_author": null,
instead of:
  "pull_request_number": ,
  "pull_request_author": "null",
The issue was that although GH_TOKEN was set in bash (verified by debug output),
it wasn't being passed to the Node.js process started by 'npx cypress'.

Changed from:
  export GH_TOKEN
  npx cypress run ...

To:
  GH_TOKEN="${GH_TOKEN}" npx cypress run ...

This ensures environment variables are explicitly passed to the child process.
**Key changes:**
- Removed pr_check.sh dependency from run-e2e-konflux-ui task
- Implemented Slack reporting directly in Tekton task
- Uses native Tekton field references for PipelineRun metadata
- Simplified message format (PipelineRun name instead of hardcoded URL)

**Benefits:**
- No more script dependencies in Tekton pipelines
- More declarative and Kubernetes-native approach
- pr_check.sh can now be removed from integration-tests or kept only for GitHub Actions
- Easier to maintain and debug

**Migration path:**
- pr_check.sh still used by GitHub Actions workflows
- Can be gradually deprecated as GitHub Actions are phased out
@testcara testcara force-pushed the main branch 3 times, most recently from ce96dac to fe3bbbd Compare March 19, 2026 10:05
@testcara testcara force-pushed the main branch 5 times, most recently from afc8fed to 6e0a746 Compare April 8, 2026 06:35
@testcara testcara force-pushed the main branch 9 times, most recently from 02e8b2f to e30c490 Compare April 8, 2026 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants