[pull] master from robotframework:master #145
Open
+156,026
−41,214
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Manage this branch in SquashTest this branch here: https://master-n02a3.squash.io |
Using `typing.get_args(x)` and `typing.get_origin(x)` is simpler than using `getattr(x, '__args__', None)` and `getattr(x, '__origin__', None)`. It also avoids problems in some corner cases. Most mportantly, it avoids issues with `Union` containing unusable `__args__` and `__origin__` in Python 3.14 alpha 6 (#5352). `get_args` (new in Python 3.8) also makes our `has_args` redundant and it is deprecated.
See PEP 649 for details. Part of Python 3.14 support (#5352).
Docs were slightly outdated after handling outputs was enhanced in #4173.
Also some cleanup to the related timeout code. Fixes #5376.
Increase the minimun dialog size a bit to match the increased font size. Make padding and font configurable using class attributes. Also make background configurable, but leave it to the default value for now. Part of #5334.
Instead of importing multiple individual items `from tkinter`, use `import tkinter as tk` and use items like `tk.Label`. There's no need to maintain the import if new items are needed, and this also avoids autoformatters splitting the long import to multiple lines.
It depends on OS how/where icons are shown. For example, on Linux with Gnone there's no icon in the dialog, but there's a taskbar icon as well as an icon in the application switcher. On Windows there's a taskbar icon and also the dialog itself has an icon. OSX is yet to be tested. This is part of #5334.
Argument is converted automatically based on the default value.
Also add test for the taskbar icon.
On Windows the timeout logic raises a `TimeoutError` without any parameters and thus its `kind` is always `TEST`. That means we cannot reliaby log the type of the occurred timeout. `TimeoutError.kind` was added for exactly this purpose in 2b9f0c7. Better to remove those changes and also document that existing `test/keyword_timeout` attributes aren't part of the public API. Fixes a bug in the implementation of #5376.
- Make the thread id an unsigned long, not long (this was changed in Python 3.7). - Update links to references (the old one didn't anymore exist). - Remove unnecessary (and apparently broken) re-try mechanism and report the error (that should never happen) directly.
When `Get Selection From User` is used with a default value, not only select that value but also activate it. That affects moving the selection with arrow keys. Now the initial position is the selection, earlier it was the first item. To some extend related to Dialog look and feel enhancements (#5334). Too small fix to deserve its own issue.
added Italian Libdoc translation
Earlier nested converters were stored in different ways depending on the converter. These instance attributes existed: - converter: TypeConverter | None - converters: tuple[TypeConverter, ...] - converters: dict[str, TypeConverter] - converters: list[tuple[Any, TypeConverter]] After this commit, attributes are: - nested: list[TypeConverter] - nested: dict[str, TypeConverter] This makes it a lot easier to have generic code that inspects nested converters. That, on the other hand, makes it easy to allow configuring how unknown nested types like `list[Unknown]` are handled. They are accepted in library keyword arguments, but with variables (#3278) that should be an error. The current design still has two problems: - It would be better to have uniform type for `nested`. Currently most TypeConverters use a list, but TypedDictConverter needs to map keys to converters and uses a dict. We probably could avoid that by storing the key to an optional attribute in TypeConverter and using a list, but that would then make finding a right converter for a key a bit more complicated and slower. - With TypeInfo normal nested converts are in `nested`, but TypedDictInfo uses separate `annotations`. That's inconsistent to TypeConverters, but changing that is not trivial. The reason is that unlike TypeConverter, TypeInfo is part of the public API so changes need to take backwards compatibility into account. That change would also affect Libdoc code and possibly also Libdoc spec files. This isn't worth the effort now, bu can be considered later, preferably in a major release.
Part of #4537.
Hopefully the final part of #4537. Review still needed.
The feature ought to now be ready so this fixes #4537.
All changes are related to argument files.
Explicitly test non-ASCII values. #5186
Changes include: - Cleanup to new collapse/expand functionality (#4888) - General style enhancements
- Simplify header implementation by using flex box layout. - Workaround Firefox issues with conditional styles. - Also some related style enhancements. Fixes #5504.
- Change row header to "Execution Errors" to more explicit and less redundant "Errors and warnings during execution" - Fine-tune styles. Most importantly, add border around error/warning messages. Fixes #4888.
Done when investigating how to fix and test #5502.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )