Repository navigation
Conversation
The specs now cover the provisioner properly on their own merits, and the coverage numbers were only ever read by a human looking at a local report — nothing gated on them and no CI job published them. Keeping SimpleCov meant carrying a development dependency, a `coverage/` artifact directory, and a Renovate stream for a gem that measures the suite rather than testing it. Removes the `simplecov` gem from the Gemfile, the `require` and `SimpleCov.start` block from `spec/spec_helper.rb`, and the `coverage` artifact path from `.gitignore`. The example count is unchanged. The YARD `doc` and `doc_coverage` rake tasks are documentation coverage, not code coverage, and are deliberately untouched. Signed-off-by: Tim Smith <tim@mondoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Removes SimpleCov and everything that existed only to serve it:
gem "simplecov", "~> 0.22"from the:testgroup inGemfilerequire "simplecov"and theSimpleCov.startblock (add_filter,add_group,enable_coverage :branch) fromspec/spec_helper.rbcoverageartifact path from.gitignoreThat is the whole footprint. There was no
minimum_coverageenforcement, noCOVERAGEenv-var branching, no coverage rake task, and no CI step that uploaded or reported coverage, so there was nothing else to take out.What this does not touch
The YARD
docanddoc_coveragerake tasks stay.doc_coveragerunsyard stats --list-undoc— that is documentation coverage, not code coverage, and it is the thing that keepslib/at 100% documented. Both still work:Also untouched: the sentence in
CONTRIBUTING.mdabout there being "no automated coverage of the Windows path yet". That is a statement about which platforms the suite exercises, not about the measurement tool, and it is still true.Why
Nothing gated on the numbers. No CI job published a report, no threshold failed a build, and the only consumer was whoever opened
coverage/index.htmllocally. What it did cost was a development dependency and a Renovate stream for a gem that measures the suite rather than testing it.The recent test work stands on its own: this removes the measurement, not a single test.
Verification
Example count is unchanged — this was verified against
origin/mainbefore the change and again after:Lint, with Cookstyle 9.0.0 / RuboCop 1.90.0 (bundle updated first so it matches what CI resolves, since
Gemfile.lockis gitignored):Greps, run from the repo root excluding
.git, both return nothing:Notes
grep -in 'simplecov\|coverage' CHANGELOG.mdis empty). SimpleCov was added after the 0.13.1 release, so it never reached published release history. Nothing was edited in that release-please-managed file.renovate/simplecov-1.x) is made obsolete by this change and should be closed once this lands. It has in fact already been closed independently, so no action is likely needed — but if Renovate reopens it, close it rather than trying to fix it. It was red because simplecov 1.x requires Ruby > 3.1 and this gemspec supports 3.1.fix:thehab svc loadrun-hook detection) has already merged intomain; this branch is cut from the resultingaac0970. It touched onlylib/kitchen/provisioner/habitat.rbandspec/kitchen/provisioner/habitat/run_command_spec.rb— notspec/spec_helper.rb, theGemfile, or theRakefile— so there is no overlap and no merge-order constraint between the two.