Repository navigation
chore: drop the dead rubocop exclusions - #20
Merged
Merged
Conversation
None of them were doing anything, and each one was a place a real offence could hide later. * `spec/**/*` — there is no `spec/` directory in this repository. * `vendor/**/*` — RuboCop already excludes `vendor/**/*` by default, along with `tmp`, `node_modules` and `.git`, so the entry was a restatement. Verified rather than assumed: `cookstyle --chefstyle` inspects the same number of files before and after, and still reports no offences. The `Style/ClassAndModuleChildren` exclusion on `lib/busser/runner_plugin/bash.rb` goes too. That cop is disabled in chefstyle, and the four sibling plugins declare their class the same compact way with no exclusion at all — so it was never suppressing anything. Signed-off-by: Tim Smith <tsmith84@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: drop the dead rubocop exclusions
None of them were doing anything, and each one was a place a real offence could
hide later.
spec/**/*— there is nospec/directory in this repository.vendor/**/*— RuboCop already excludesvendor/**/*by default, along withtmp,node_modulesand.git, so the entry was a restatement.Verified rather than assumed:
cookstyle --chefstyleinspects the same number offiles before and after, and still reports no offences.
The
Style/ClassAndModuleChildrenexclusion onlib/busser/runner_plugin/bash.rbgoes too. That cop is disabled in chefstyle,and the four sibling plugins declare their class the same compact way with no
exclusion at all — so it was never suppressing anything.