Skip to content

Conversation

@Aashiq-J
Copy link
Member

@Aashiq-J Aashiq-J commented Sep 12, 2025

Description

Issue: Update Observability agent modules to tag the cluster

Add user tags to the cluster, so that ROKS UI shows logging status as active. more info
Uploading Screenshot 2025-09-12 at 1.17.35 PM.png…

Release required?

  • No release
  • Patch release (x.x.X)
  • Minor release (x.X.x)
  • Major release (X.x.x)
Release notes content

Run the pipeline

If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.

Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:

/run pipeline

Checklist for reviewers

  • If relevant, a test for the change is included or updated with this PR.
  • If relevant, documentation for the change is included or updated with this PR.

For mergers

  • Use a conventional commit message to set the release level. Follow the guidelines.
  • Include information that users need to know about the PR in the commit message. The commit message becomes part of the GitHub release notes.
  • Use the Squash and merge option.

@Aashiq-J Aashiq-J requested a review from jor2 as a code owner September 12, 2025 07:47
@Aashiq-J
Copy link
Member Author

/run pipeline

kind: solution
catalog_id: 7df1e4ca-d54c-4fd0-82ce-3d13247308cd
offering_id: b0a00765-ee91-4c2a-87fc-df46dbc58cdb
include_git_submodules: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you leave a code comment saying why this is needed?

Copy link
Contributor

@ocofaigh ocofaigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We defo need documentation on this - perhaps the DA overview page should have a link to a markdown doc in our repo which explains more about this hook?

@Aashiq-J
Copy link
Member Author

/run pipeline

@jor2
Copy link
Member

jor2 commented Sep 16, 2025

Can see its a bit of a pain to get the instance_id just thinking if we should instead be using a null_resource block with your script instead of having only one repo using ansible. I'll leave it up to @ocofaigh.

@jor2
Copy link
Member

jor2 commented Oct 16, 2025

@Aashiq-J @ocofaigh has this been implemented in another pr or are we still planning on doing this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants