This repository was archived by the owner on Nov 24, 2023. It is now read-only.
enable worker patch #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modules/vpc-openshift/variables.tf
Outdated
| } | ||
|
|
||
| variable "patch_version" { | ||
| description = "Updates the worker nodes with the required patch version, patch_version_fixpack_version ." |
There was a problem hiding this comment.
Description should be
Updates the worker nodes with the required patch version. The patch_version should be in the format: patch_version_fixpack_version.
| tags = var.tags | ||
| cos_instance_crn = var.cos_instance_crn | ||
| force_delete_storage = var.force_delete_storage | ||
| kms_config = var.kms_config |
There was a problem hiding this comment.
Update the vpc-openshift example (directory: examples/vpc-openshift) as well with patch_version ( showing how to pass patch_version from example template)
Changed description of patch_version variable
Added variable in example
Updated patch_version in example
hkantare
approved these changes
Jun 7, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request enables patch_version update for the cluster
https://registry.terraform.io/providers/IBM-Cloud/ibm/latest/docs/resources/container_vpc_cluster#patch_version
Types of changes in this PR
Changes that affect the core Terraform module or submodules
Changes that don't affect the core Terraform module or submodules
Release required?
Identify the type of release. For information about the changes in a semantic versioning release, see Release versioning.
x.x.X)x.X.x)X.x.x)Release notes content
Run the pipeline
If the CI pipeline doesn't run when you create the PR, the PR requires a user with GitHub collaborators access to run the pipeline.
Run the CI pipeline when the PR is ready for review and you expect tests to pass. Add a comment to the PR with the following text:
Checklist for reviewers
Merge actions for mergers