Skip to content

Conversation

@DrFaust92
Copy link
Contributor

No description provided.

Signed-off-by: drfaust92 <[email protected]>
@DrFaust92 DrFaust92 marked this pull request as ready for review November 19, 2025 20:55
@DrFaust92 DrFaust92 requested review from a team, apeabody and ericyz as code owners November 19, 2025 20:55
@apeabody
Copy link
Collaborator

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for configuring transparent huge pages for GKE node pools. The changes are applied across multiple modules and include documentation, variable definitions, and logic in the Terraform templates. The implementation looks mostly correct, but I've found a couple of issues. There's an incorrect key used in a Terraform template which should be fixed for consistency and clarity, and a test data file contains an invalid value which appears to be a copy-paste error. Please see my detailed comments for suggestions.

Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

/gcbrun

@DrFaust92
Copy link
Contributor Author

apeabody anything i can help with/issue with my config

@apeabody
Copy link
Collaborator

/gcbrun

@apeabody
Copy link
Collaborator

apeabody anything i can help with/issue with my config

Thanks @DrFaust92 - The most recent failure was due to a flake, I've re-triggered the test.

@apeabody
Copy link
Collaborator

This error has come up during several test runs:

Step #57 - "apply simple-windows-node-pool-local":         	Error:      	Received unexpected error:
Step #57 - "apply simple-windows-node-pool-local":         	            	FatalError{Underlying: error while running command: exit status 1; 
Step #57 - "apply simple-windows-node-pool-local":         	            	Error: NodePool win-pool-01 was created in the error state "ERROR"
Step #57 - "apply simple-windows-node-pool-local":         	            	
Step #57 - "apply simple-windows-node-pool-local":         	            	  with module.this.module.gke.google_container_node_pool.windows_pools["win-pool-01"],
Step #57 - "apply simple-windows-node-pool-local":         	            	  on ../../../modules/beta-public-cluster/cluster.tf line 1133, in resource "google_container_node_pool" "windows_pools":
Step #57 - "apply simple-windows-node-pool-local":         	            	1133: resource "google_container_node_pool" "windows_pools" {
Step #57 - "apply simple-windows-node-pool-local":         	            	}
Step #57 - "apply simple-windows-node-pool-local":         	Test:       	TestSimpleWindowsNodePool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants