-
Notifications
You must be signed in to change notification settings - Fork 1.3k
feat: add support for transparent huge pages configs #2464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for configuring transparent huge pages for GKE node pools. The changes are applied across multiple modules and include documentation, variable definitions, and logic in the Terraform templates. The implementation looks mostly correct, but I've found a couple of issues. There's an incorrect key used in a Terraform template which should be fixed for consistency and clarity, and a test data file contains an invalid value which appears to be a copy-paste error. Please see my detailed comments for suggestions.
Signed-off-by: drfaust92 <[email protected]>
Signed-off-by: drfaust92 <[email protected]>
|
/gcbrun |
|
/gcbrun |
|
apeabody anything i can help with/issue with my config |
|
/gcbrun |
Thanks @DrFaust92 - The most recent failure was due to a flake, I've re-triggered the test. |
|
This error has come up during several test runs: |
No description provided.