Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multi Window support for Samsung devices #339

Merged
merged 1 commit into from
Jun 13, 2017

Conversation

bumper314
Copy link
Contributor

A single meta-data entry is enough to make Termux "Multi Window" aware on supported Samsung devices.
Tested and confirmed working on Samsung Note Pro 12.2 running Android 5.1.1.
screenshot_2017-06-12-01-22-28

This addition should not interfere with Android 6+'s split screen feature.
Tested and confirmed split screen functions as normal on a Nexus 6 running Android 7.0.

This addition should go unnoticed on non-Smasung Android 5 devices.
Tested and confirmed no functionality visible on Nexus 5 running Android 5.1.

A single meta-data entry is enough to make Termux "Multi Window" aware on supported Samsung devices.
Tested and confirmed working on Samsung Note Pro 12.2 running Android 5.1.1.

This addition should not interfer with Android 6+'s split screen feature.
Tested and confirmed split screen functions as normal on a Nexus 6 running Android 7.0.

This addition should go unnoticed on non-Smasung Android 5 devices.
Tested and confirmed no functionality visible on Nexus 5 running Android 5.1.
@fornwall
Copy link
Member

Looks great!

This addition should not interfere with Android 6+'s split screen feature.

I guess this should be Android 7, as that was the version that introduced split screen AFAIK (https://developer.android.com/guide/topics/ui/multi-window.html)?

For my understanding: Does this affect also Samsung devices running Android 7.0 or later (does it change/improve the multiwindow handling on that version, or does Samsung just use the built-in Android multiwindow support as of 7.0+ regardless of the com.sec.android.support.multiwindow meta-data)?

@bumper314
Copy link
Contributor Author

I guess this should be Android 7, as that was the version that introduced split screen AFAIK

Correct, my mistake.

For my understanding: Does this affect also Samsung devices running Android 7.0 or later (does it change/improve the multiwindow handling on that version, or does Samsung just use the built-in Android multiwindow support as of 7.0+ regardless of the com.sec.android.support.multiwindow meta-data)?

I'm confident that Samsung will choose Android 7's multi-window over their own if both are present: http://developer.samsung.com/galaxy/multiwindow

Does anyone have a Samsung device on Android 7 who can confirm?
Here's an APK http://d.pr/f/w2he6z

@bumper314
Copy link
Contributor Author

Just tested on two Samsung tablets.

  • Android 6 works as expected using Samsung's multi-window support.
  • Android 7 works as expected, and appears to use Android 7's native split-screen with some additional feature (like being able to pop up a floating window).

Seems like a fairly safe merge. After that, I'll look into supporting multiple instances (which Samsung's multi window API supports) leveraging this merge request:
#187

@bumper314
Copy link
Contributor Author

Just noticed this addresses Issue #29

@fornwall fornwall merged commit ed3a326 into termux:master Jun 13, 2017
@fornwall
Copy link
Member

@bumper314 Thanks a lot - this will be available in a v0.52 update available later today!

@yajo
Copy link

yajo commented Jun 13, 2017

Amazing how simple this was! I don't understand why don't everybody add it...
Thanks!

AdamMickiewich pushed a commit to VolyaTeam/dzida-app that referenced this pull request Aug 8, 2022
Add Multi Window support for Samsung devices
shrihankp pushed a commit to reisxd/termux-app that referenced this pull request Oct 20, 2022
Add Multi Window support for Samsung devices
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants