Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add APIs to help migration to Farkle 7. #366

Open
wants to merge 7 commits into
base: mainstream
Choose a base branch
from

Conversation

teo-tsirpanis
Copy link
Owner

Fixes #351.

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 9 changed files in this pull request and generated 2 comments.

Files not reviewed (4)
  • src/Farkle/Farkle.fs: Language not supported
  • src/Farkle/Obsoletions.cs: Evaluated as low risk
  • src/Farkle/Builder/Terminal.cs: Evaluated as low risk
  • src/Farkle/Builder/GrammarBuilderExtensions.cs: Evaluated as low risk
Comments suppressed due to low confidence (5)

src/Farkle/Compatibility/EnumerableCompat.cs:9

  • [nitpick] The method name 'Order' is ambiguous. It should be renamed to 'OrderByDefault' to improve readability.
public static IOrderedEnumerable<T> Order<T>(this IEnumerable<T> enumerable) => enumerable.OrderBy(x => x);

src/Farkle/Builder/Regex.cs:337

  • Ensure that the behavior introduced by the Order method in NotOneOf(IEnumerable chars) is covered by tests.
public static Regex NotOneOf(IEnumerable<char> chars)

src/Farkle/Builder/Regex.cs:396

  • Ensure that the behavior introduced by the Order method in OneOf(IEnumerable chars) is covered by tests.
public static Regex OneOf(IEnumerable<char> chars)

src/Farkle/Builder/Regex.cs:666

  • Verify that the migration guidance provided for the And method is clear and accurate.
[Obsolete("Use the + operator instead.", DiagnosticId = Obsoletions.RegexAndOrCode, UrlFormat = Obsoletions.SharedUrlFormat)]

src/Farkle/Builder/Regex.cs:679

  • Verify that the migration guidance provided for the Or method is clear and accurate.
[Obsolete("Use the | operator instead.", DiagnosticId = Obsoletions.RegexAndOrCode, UrlFormat = Obsoletions.SharedUrlFormat)]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review potential APIs to help migration to Farkle 7 and decide on them.
1 participant