[Clean-up] Clang-format some existing files #3179
Conversation
veblush
force-pushed
the
code-format
branch
from
3ec466f to
74e10e3
Compare
veblush
force-pushed
the
code-format
branch
from
74e10e3 to
d332bb8
Compare
| struct MinMaxReducerCompare { | ||
| MinMaxReducerCompare() = delete; | ||
| MinMaxReducerCompare(MinMaxEvalType evalType) : type_(evalType){}; | ||
| MinMaxReducerCompare(MinMaxEvalType evalType) : type_(evalType) {}; |
There was a problem hiding this comment.
I believe the Google style rules say that a space is not allowed between the parenthesis and the brace, and my IDE with it's auto formatting agrees. But the Pigweed style checker says that this is wrong and spacing must be there. I am much interested in your final resolution of this. This difference has only appeared in the last year or so.
There was a problem hiding this comment.
I'm sticking with the current format because it follows the rule "There should be a space between the close parenthesis and the open curly brace." (link
Given that the Pigweed style is implemented by clang-format (following Google conventions), the practical decision is to treat the tool's output as the final authority, overriding minor written style guide disagreements.
BUG=SImple-clean-up