Support for Pluggable Devices #8524
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cromefire
changed the title
|
Seems good now. At least it loads the library. Can't test actually fully loading the a lib end to end right now as my target system has not enough memory to compile the tensorflow extension and I'll have to find a way to cross-compile it first (issues with missing instructions and libc versions and the like...). It does try to load the extension correctly though and as it's only the libtensorflow C path from there, it'd say it looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8040
Please do thoroughly review the PR for memory safety in the C code, as I'm certainly not qualified to write any C code.