Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade tfjs from 0.11 to 0.12 in examples #105

Merged
merged 2 commits into from
Jul 5, 2018
Merged

Conversation

caisq
Copy link
Collaborator

@caisq caisq commented Jul 3, 2018

Also change ^ to ~ in the version strings, so that upgrades like this won't be absolutely necessary in the future.


This change is Reviewable

@caisq caisq requested review from dsmilkov, nsthorat and davidsoergel and removed request for dsmilkov July 3, 2018 17:25
@nsthorat
Copy link

nsthorat commented Jul 3, 2018

:lgtm_strong:


Review status: :shipit: complete! 1 of 1 LGTMs obtained


addition-rnn/package.json, line 13 at r1 (raw file):

  "dependencies": {
    "@tensorflow/tfjs": "~0.12.0",
    "vega-embed": "^3.0.0"

can you update these to ~ while you are here?


Comments from Reviewable

@dsmilkov
Copy link
Contributor

dsmilkov commented Jul 3, 2018

I made them ^ so that we are "forced" to keep our examples up to date with our API. Using ~ will take the examples much more stable, but then we can be lazy about upgrading them


Review status: :shipit: complete! 1 of 1 LGTMs obtained


Comments from Reviewable

instead of ~
Copy link
Collaborator Author

@caisq caisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done switching back to ^

Reviewable status: :shipit: complete! 1 of 1 LGTMs obtained

@caisq caisq merged commit cc4a746 into tensorflow:master Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants