Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interface should be public for external usage #522

Merged
merged 3 commits into from
Feb 29, 2024

Conversation

nfeybesse
Copy link
Contributor

No description provided.

Copy link

google-cla bot commented Feb 26, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@Craigacp
Copy link
Collaborator

@nfeybesse once you've signed the CLA we can run the CI and get this merged in.

@nfeybesse
Copy link
Contributor Author

Hello, I signed the CLA yesterday normally

@karllessard
Copy link
Collaborator

Hey @nfeybesse , you got some spotless checks errors being raised by the CI/CD. It is possible that you are not the author of the errors, though as soon as a file is touched and has never been scanned before with spotless, errors are raised.

Can you please run mvn spotless:apply at the root of your project and push the changes?

@nfeybesse
Copy link
Contributor Author

I seem to have already done this, the command was executed successfully and nothing was modified. I will confirm tomorrow

@karllessard
Copy link
Collaborator

I seem to have already done this, the command was executed successfully and nothing was modified. I will confirm tomorrow

I can already see a few non-compliant syntax, including missing spaces, missing braces, etc. Something you can do to help is to enable the Google Java Format in your IDE (if it is IntelliJ, there is a plugin for that).

@Craigacp Craigacp merged commit 3f89f60 into tensorflow:master Feb 29, 2024
9 checks passed
@Craigacp
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants