fix: add cross-domain cookie navigation for UK/regional users#178
fix: add cross-domain cookie navigation for UK/regional users#178Jah-yee wants to merge 2 commits intoteng-lin:mainfrom
Conversation
After login, navigate to accounts.google.com and myaccount.google.com to ensure .google.com cookies are set (not just regional variants like .google.co.uk). This fixes authentication failures for users in the UK and other regions where Google's login flow sets cookies on regional domains that notebooklm.google.com rejects. Fixes teng-lin#146
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical authentication issue affecting users in specific geographical regions, such as the UK. By introducing a series of post-login navigations, it ensures that the necessary .google.com cookies are correctly propagated across domains, thereby resolving instances where regional domain cookies (e.g., .google.co.uk) were not recognized by notebooklm.google.com. This change significantly improves the login experience and accessibility for a segment of the user base. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request adds a helpful fix for users in regions with country-specific Google domains by navigating to global Google domains to set the correct cookies. The implementation is sound. I have two suggestions to improve the code: one for adhering to the project's logging style, and another to refactor the navigation logic for better maintainability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
|
Thanks for the contribution here — really appreciate you taking the time to investigate and propose a fix for the regional cookie issue. We already have an earlier PR open for the same problem in #151, so I’m going to close this one as a duplicate to keep the discussion in one place. Thanks again for the help. |
Description
After login, navigate to accounts.google.com and myaccount.google.com to ensure .google.com cookies are set (not just regional variants like .google.co.uk). This fixes authentication failures for users in the UK and other regions where Google's login flow sets cookies on regional domains that notebooklm.google.com rejects.
Fix
Testing
This fix addresses the issue described in #146 where UK users get cookies on .google.co.uk that notebooklm.google.com rejects.
Closes #146