Skip to content

fix(auth): force .google.com cookies during login for regional users #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
teng-lin merged 2 commits into from
Mar 11, 2026
Merged

fix(auth): force .google.com cookies during login for regional users #151

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b96a4a8
fix(auth): force .google.com cookies during login for regional users
teng-lin Mar 4, 2026
ed87c87
refactor(auth): extract login URLs into constants
teng-lin Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/notebooklm/cli/session.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -221,6 +221,11 @@ def login(storage):

input("[Press ENTER when logged in] ")

# Force .google.com cookies for regional users (e.g. UK lands on
# .google.co.uk). Use "load" not "networkidle" to avoid analytics hangs.
page.goto("https://accounts.google.com/", wait_until="load")
page.goto("https://notebooklm.google.com/", wait_until="load")
Copy link

@gemini-code-assist gemini-code-assist bot Mar 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve maintainability and avoid magic strings, consider defining these URLs as constants at the module level. This would also allow reusing the NOTEBOOKLM_URL constant, as "https://notebooklm.google.com/" is hardcoded elsewhere in this file (e.g., line 215).

For example, you could add at the top of the file:
ACCOUNTS_GOOGLE_URL = "https://accounts.google.com/"
NOTEBOOKLM_URL = "https://notebooklm.google.com/"
And then use page.goto(ACCOUNTS_GOOGLE_URL, ...) and page.goto(NOTEBOOKLM_URL, ...) here.


current_url = page.url
if "notebooklm.google.com" not in current_url:
console.print(f"[yellow]Warning: Current URL is {current_url}[/yellow]")
Expand Down