Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added progress method (#777) and added typing to external methods. #778

Merged
merged 1 commit into from
May 17, 2024

Conversation

SteveMcGrath
Copy link
Contributor

This refactor is the initial stage of a larger refactor and modernization attempt to reduce the python 2 code within the packages.

This also addresses issue #777 of the missing progress method

Fixes #777

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Updated test suite with new method
  • Removed tests that were no longer necessary

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@SteveMcGrath SteveMcGrath requested a review from a team as a code owner May 17, 2024 16:10
This refactor is the initial stage of a larger refactor and modernization attempt to reduce the python 2 code within the packages.

This also addresses issue #777 of the missing progress method
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
79.2% Coverage on New Code (required ≥ 95%)

See analysis details on SonarCloud

@SteveMcGrath SteveMcGrath merged commit ebb79be into master May 17, 2024
15 of 16 checks passed
@SteveMcGrath SteveMcGrath deleted the feature/777 branch May 17, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

There is no "scan.progress" endpoint
2 participants