Fix module path, remove x/exp, and fix AsyncBufferTime ticker#3
Open
Fix module path, remove x/exp, and fix AsyncBufferTime ticker#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
github.com/tempurai/coacross modules and docs.AsyncBufferTimefrom stalling and leaking goroutines by guaranteeing buffered batches are emitted on time boundaries and the ticker is stopped when the source ends.golang.org/x/expto avoid proxy/fetch issues and provide a localOrderedconstraint.Description
go.modandbenchmark/go.mod, adjustedreplaceinbenchmark/go.mod, and replaced imports across the codebase from the old path togithub.com/tempurai/co.golang.org/x/expusage by adding a localOrderedtype inutils.goand using the standardslicespackage where appropriate.AsyncBufferTimeSequenceinasync_buffer_time_sequence.goby addingtickerStop,tickerStopOnce, a ticker goroutine that broadcasts onintervalboundaries, and astopTickercall when the source completes to avoid stalled goroutines.README.mdto point tohttps://pkg.go.dev/github.com/tempurai/co, addedGOPROXY=directexample, and bumpedgoversion to1.22in module files.Testing
GOPROXY=direct GOSUMDB=off go mod tidyandgo test ./...in CI or a network-enabled local environment.Codex Task