Skip to content

fix(golden): sort challenge-id canonical JSON by code point, not locale #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MattewGraham wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(golden): sort challenge-id canonical JSON by code point, not locale #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a91cff8
fix(policy): make directory-style path patterns match in conformance …
MattewGraham Jul 14, 2026
4eb8d56
fix(policy): make directory-style path patterns match in conformance …
MattewGraham Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion conformance/golden/adapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,8 +85,12 @@ function stableStringify(value: unknown): string {
}

if (value && typeof value === 'object') {
// Sort by Unicode code point, never by locale: this string feeds the
// challenge-id HMAC, and localeCompare both diverges from the other
// SDKs (which sort by code point) and varies with the runtime's ICU
// data, making the reference id environment-dependent.
const entries = Object.entries(value as Record<string, unknown>).sort(([left], [right]) =>
left.localeCompare(right),
left < right ? -1 : left > right ? 1 : 0,
)
return `{${entries
.map(([key, item]) => `${JSON.stringify(key)}:${stableStringify(item)}`)
Expand Down
24 changes: 24 additions & 0 deletions conformance/vectors/challenge-id.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -519,6 +519,30 @@
}
},
"expected": "WqQuVsD-d0Uij4uzx-W_MdUc4wo6wpIuvHNvPIw6G9M"
},
{
"name": "mixed_case_key_ordering",
"description": "Canonical request JSON must sort keys by Unicode code point (uppercase before lowercase), not locale collation",
"tags": [
"happy-path",
"canonicalization"
],
"input": {
"secretKey": "case-sensitive-key",
"realm": "api.example.com",
"method": "tempo",
"intent": "charge",
"request": {
"amount": "1000000",
"Currency": "USD",
"ZONE": "eu-1",
"network": {
"chainId": 42431,
"Layer": "L2"
}
}
},
"expected": "WXjRL_umEnaXW00KDPpLZrhhlolHNkHK_I5y-cIShdE"
}
]
}