fix(server): require default challenge expiry#39
Open
EfeDurmaz16 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
expireseven whenVerifyParams.Expireswas not explicitly setWhy
VerifyOrChallengeissues challenges with a default five-minute expiry whenVerifyParams.Expiresis empty. Verification should enforce that same effective expiry policy. Previously the missing-expires check only ran whenparams.Expireswas explicitly set, so credentials without anexpiresfield could pass the default-expiry path.Verification
go test ./pkg/server -run TestVerifyOrChallenge_RejectsMissingDefaultExpires -count=1failed before the fixgo test ./pkg/server -run TestVerifyOrChallenge -count=1go test ./...