-
Notifications
You must be signed in to change notification settings - Fork 17
feat: adopt wata device-code transport for cli auth #750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jxom
wants to merge
9
commits into
main
Choose a base branch
from
jxom/wata-device-code
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
c872eac
feat: adopt wata device-code transport for cli auth
jxom 16ea71e
Merge remote-tracking branch 'origin/main' into jxom/wata-device-code
jxom 420553c
feat: support access key limit updates over device code
jxom 5f31724
feat: add device code handler
jxom a3c6a68
deprecate legacy CLI auth
jxom 7fe83b0
fix device code compatibility
jxom dc76f4f
add device code approval validation
jxom dc502fa
fix: harden device code approvals
jxom cc9af34
preserve device code limit periods
jxom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| --- | ||
| 'accounts': minor | ||
| --- | ||
|
|
||
| Rewrote `accounts/cli` onto the Wata device-code transport and deprecated `CliAuth` and `Handler.codeAuth` in favor of `Handler.deviceCode`. | ||
|
|
||
| ```diff | ||
| - Provider.create({ | ||
| - host: 'https://wallet.example.com/api/auth/cli', | ||
| - pollIntervalMs: 1000, | ||
| - timeoutMs: 60_000, | ||
| - }) | ||
| + Provider.create({ | ||
| + host: 'https://wallet.example.com/auth/device', | ||
| + pollingInterval: 1000, | ||
| + timeout: 60_000, | ||
| + }) | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| --- | ||
| 'accounts': minor | ||
| --- | ||
|
|
||
| Added a `deviceCode` adapter (`accounts/deviceCode`) that forwards wallet RPC through the Wata device-code transport (RFC 8628 with PKCE), with a `tempoWallet` preset. | ||
|
|
||
| ```ts | ||
| import { deviceCode } from 'accounts/deviceCode' | ||
|
|
||
| const adapter = deviceCode({ | ||
| name: 'Example CLI', | ||
| onPrompt: ({ userCode, verificationUriFull }) => console.log(userCode, verificationUriFull), | ||
| rdns: 'com.example.cli', | ||
| url: 'https://wallet.tempo.xyz/auth/device', | ||
| }) | ||
| ``` |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,7 +11,6 @@ | |
| "/auth", | ||
| "/auth/*", | ||
| "/me", | ||
| "/cli-auth/*", | ||
| "/webauthn/*", | ||
| "/relay", | ||
| "/fortune", | ||
|
|
||
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.